Skip to content

Conversation

@stefanunity
Copy link
Collaborator

@stefanunity stefanunity commented Jan 28, 2025

Description

Testing status & QA

  • CI green

Overall Product Risks

  • Low risk, 2019.4 hasn't been supported in a long time

  • Complexity: low

  • Halo Effect: low, just input system itself

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@stefanunity stefanunity requested a review from ekcoh January 28, 2025 10:55
@stefanunity stefanunity changed the title CHANGE: increase minimum package version to 2021.3 CHANGE: increase minimum package version to 2021.3 + some maintenance Jan 28, 2025
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to see a PR reducing total amount of code. Thanks for doing this @stefanunity. Changes LGTM.

@stefanunity stefanunity merged commit 528e824 into develop Jan 28, 2025
123 checks passed
@stefanunity stefanunity deleted the increase-min-editor-version branch January 28, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants